Parse tspconfig as yaml to be able to figure out where errors are#2273
Merged
Conversation
Contributor
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2273/ |
timotheeguerin
commented
Aug 8, 2023
timotheeguerin
changed the title
timotheeguerin
commented
Aug 9, 2023
timotheeguerin
marked this pull request as ready for review
August 9, 2023 17:58
timotheeguerin
requested review from
allenjzhang,
bterlson,
daviwil and
markcowl
as code owners
August 9, 2023 17:58
markcowl
reviewed
Aug 17, 2023
markcowl
left a comment
markcowl
left a comment
Contributor
There was a problem hiding this comment.
Would also be nice to see the impact on typespec-azure
markcowl
approved these changes
Sep 7, 2023
markcowl
left a comment
markcowl
left a comment
Contributor
There was a problem hiding this comment.
Please file an uptake PR in Azure/typespec-azure before merging.
Member
Author
|
allenjzhang
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2298
Update yaml parser library from
js-yamltoyamlwhich allow us to have an ast and resolve where values are coming from.Before
On top of providing error locations for config errors that the compiler can resolve this also setup the base to provide the ability for an emitter to report na error on its emitter options and show where it is.