Fix: Shared route body should use anyOf instead of oneOf#2366
Merged
Conversation
timotheeguerin
requested review from
allenjzhang,
bterlson,
daviwil and
markcowl
as code owners
September 5, 2023 20:12
Contributor
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2366/ |
daviwil
approved these changes
Sep 6, 2023
daviwil
left a comment
daviwil
left a comment
Contributor
There was a problem hiding this comment.
I wonder if this affects any samples on typespec-azure
Member
Author
might need to regen the samples for the openapi output but it shouldn't be a major change, I'll make a PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2303
We don't know if those bodies are mutually exclusive so
anyOfis more correct.