Fix: Crash when comparing recursive models#2379
Merged
timotheeguerin merged 3 commits intoSep 6, 2023
Merged
Conversation
added 2 commits
September 6, 2023 14:03
timotheeguerin
requested review from
allenjzhang,
bterlson,
daviwil and
markcowl
as code owners
September 6, 2023 21:09
Contributor
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/2379/ |
bterlson
reviewed
Sep 6, 2023
…_2023-09-06-21-08.json Co-authored-by: Brian Terlson <brian.terlson@microsoft.com>
bterlson
reviewed
Sep 6, 2023
| enum Related { | ||
| false = 0, | ||
| true = 1, | ||
| maybe = 2, |
Member
There was a problem hiding this comment.
I feel like "unknown" describes this situation better than "maybe", maybe.
Member
Author
There was a problem hiding this comment.
Typescript also has unknown so I kept the same naming
from their docs
* Generally, Ternary.Maybe is used as the result of a relation that depends on itself, and
* Ternary.Unknown is used as the result of a variance check that depends on itself. We make
* a distinction because we don't want to cache circular variance check results.
bterlson
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1991
Compiler would get into a infinite recursion when comparing recursive models.