Skip to content

fix: respect custom property & field nullability - #9167

Merged
jorgerangel-msft merged 1 commit into
microsoft:mainfrom
jorgerangel-msft:fix-enum-nullability
Dec 9, 2025
Merged

fix: respect custom property & field nullability#9167
jorgerangel-msft merged 1 commit into
microsoft:mainfrom
jorgerangel-msft:fix-enum-nullability

Conversation

@jorgerangel-msft

@jorgerangel-msft jorgerangel-msft commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@pkg-pr-new

pkg-pr-new Bot commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http@9167

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client@9167

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-client-csharp@9167

commit: c16548a

@github-actions

github-actions Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

No changes needing a change description found.

@azure-sdk

azure-sdk commented Dec 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@jorgerangel-msft
jorgerangel-msft force-pushed the fix-enum-nullability branch 2 times, most recently from 3fbb7eb to c16548a Compare December 9, 2025 19:13
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Dec 9, 2025
@jorgerangel-msft jorgerangel-msft changed the title fix: respect property & field nullability fix: respect custom property & field nullability Dec 9, 2025
@jorgerangel-msft
jorgerangel-msft marked this pull request as ready for review December 9, 2025 20:36
@jorgerangel-msft
jorgerangel-msft added this pull request to the merge queue Dec 9, 2025
Merged via the queue into microsoft:main with commit 1c3426f Dec 9, 2025
22 checks passed
@jorgerangel-msft
jorgerangel-msft deleted the fix-enum-nullability branch December 9, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes
@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner
@christothes christothes Awaiting requested review from christothes
@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

Assignees

No one assigned

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom Code can't change property nullability

3 participants

@jorgerangel-msft @azure-sdk @JoshLove-msft