security: upgrades nerdbank message pack version#1427
Closed
baywet wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the centrally-managed NuGet dependency version for Nerdbank.MessagePack to address the security advisory referenced in the PR description and unblock restores that are failing due to the vulnerable version.
Changes:
- Bump
Nerdbank.MessagePackfrom1.0.11to1.1.62via central package management.
| <PackageVersion Include="Microsoft.VisualStudio.Threading" Version="$(VisualStudioThreadingVersion)" /> | ||
| <PackageVersion Include="Microsoft.VisualStudio.Validation" Version="17.13.22" /> | ||
| <PackageVersion Include="Nerdbank.MessagePack" Version="1.0.11" /> | ||
| <PackageVersion Include="Nerdbank.MessagePack" Version="1.1.62" /> |
Member
|
Thanks for volunteering this. We'll go with #1430 instead of this PR because this PR targets an unreleased version and you probably want a release sooner rather than later. That said, you can workaround this locally by adding a direct reference to the Nerdbank.MessagePack package yourself, or if you're using CPVM, just add a PackageVersion item to Directory.Packages.props to the same dependency (and turn on transitive pinning). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1415
fixes #1426
due to this advisory, restores are failing on a bunch of projects. GHSA-2cwq-pwfr-wcw3
This pull request upgrade the dependency in an attempt to release and fix the issue.
However I was not able to test things out locally since https://dev.azure.com/azure-public/vside/_artifacts/feed/msft_consumption_public does not have that specific version, and I couldn't figure out how to get the permissions to do so.
Nuking the nuget config locally results in quite a few unit tests failing. Not sure how to proceed from there?