Implement NoThrowAwaitable for ValueTask and ValueTask<TResult>#1193
Merged
Conversation
AArnott
requested changes
Jun 5, 2023
AArnott
left a comment
AArnott
left a comment
Member
There was a problem hiding this comment.
All these changes look good. But I don't see a single test that actually demonstrates the recommended usage pattern. Can you add that? Maybe as a [Theory] that takes a bool so that it can exercise the passing or failure path based on the bool value.
sharwell
force-pushed
the
no-throw-valuetask
branch
from
June 5, 2023 18:42
e8896e6 to
d3cab5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.