Fix deadlock in AsyncQueue<T>.DequeueAsync cancellation #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few changes for this:
That last point means that basically the
ThreadPool.QueueUserWorkItemdelegate is dead code, since the only caller forAttachCancellationright now will never complete the TaskCompletionSource while this method is executing, leaving only the cancellation case. But since this method might be used in other places in the future, I thought we should make sure it is fully implemented. I used the debugger to manually test that code path to ensure correctness.Fixes #458