Fix hang due to config provider timeout - #13909
Merged
Colen Garoutte-Carson (Colengms) merged 2 commits intoSep 8, 2025
Merged
Conversation
Colen Garoutte-Carson (Colengms)
requested a review
from a team
as a code owner
September 8, 2025 22:34
Sean McManus (sean-mcmanus)
approved these changes
Sep 8, 2025
Colen Garoutte-Carson (Colengms)
deleted the
dev/coleng/fix_custom_config_async
branch
September 8, 2025 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13862
The issue appears to be that the timeout causes a
vscode.window.showInformationMessage, which was being awaiting. If the user does not dismiss it, the function would not return and would fail to indicate that the custom configuration request is complete.The fix is to not await it.