Update IntelliSense loc strings for PR 757614. - #14607
Merged
Merged
Conversation
Contributor
Author
|
This PR is in draft until have time to get back to addressing the comments in PR 757614. |
Colengms
approved these changes
Jul 27, 2026
Colengms
previously approved these changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sean-mcmanus
marked this pull request as ready for review
August 3, 2026 15:21
bobbrow
previously approved these changes
Aug 3, 2026
Contributor
Author
|
This should get checked in with 757614. |
bobbrow
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ IntelliSense language server can now emit an additional diagnostic
message. Its localized message tables under Extension/bin/messages//messages.json
are positional arrays indexed by message ID, so every locale's array must be at
least as long as the highest message ID the server can produce. A locale whose
array was shorter than the new message's index would hit an out-of-range lookup
when that diagnostic was emitted, failing the language server for that locale.
This adds the new English string to every locale's table so all locales stay in
sync. The entry is intentionally left in English for now; localized translations
will arrive later through the normal translation-import pipeline.
Message table update
Appended the new string to all 13 locale files in Extension/bin/messages:
"too many nested user-defined conversions (possible cycle of converting constructors)"
It is added at the same positional index in every locale, matching the new
message ID, so lookups line up across all languages.