This repository was archived by the owner on Jul 20, 2026. It is now read-only.
Use ENV key=value in Dockerfile templates - #2344
Merged
bwateratmsft merged 1 commit intoSep 23, 2020
Merged
Conversation
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
bwateratmsft
approved these changes
Sep 23, 2020
bwateratmsft
left a comment
bwateratmsft
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks @StefanScherer!
|
Thanks! FWIW (for people arriving here); both syntaxes will continue to be supported, but the syntax without |
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In our docs.docker.com we've removed the examples that used the old syntax
ENV key valueand replaced it with the betterENV key=valuesyntax (related docker/docs#11414).The old style had its problems when using multiple environment variables
ENV ONE TWO= THREE=worldJust yesterday I used the Docker extension in preparation for a Docker beginners video course and saw that the Docker extension uses the old style.
This PR changes the templates to the new style and helps users to use the good practice.