Improvement: Account for temporary nodes in the tree view#233
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the robustness of tree view operations by handling temporary nodes that may not have string IDs. The change prevents runtime errors when checking for retry nodes in tree elements that include temporary nodes created by showCreatingChild.
Key Changes:
- Added type guard to safely check for string IDs before calling string methods
- Added explanatory comment documenting the necessity of the type check
tnaum-ms
force-pushed
the
dev/tnaum/temporary-tree-items-fix
branch
from
4581442 to
c9273e1
Compare
bk201-
approved these changes
Aug 25, 2025
github-project-automation
Bot
moved this from In progress
to Done
in DocumentDB for VSCode: Release Plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.