Improvement: nonNull calls with better debugging information#236
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances debugging capabilities by replacing usage of nonNullValue and related functions from @microsoft/vscode-azext-utils with local implementations that include better debugging information. The key improvement is adding file context to error messages to help with triage when null/undefined values are encountered.
- Updates all existing
nonNull*function calls to include requiredmessageanddetailsparameters - Adds ESLint rule to prevent future usage of external nonNull helpers
- Updates documentation with guidelines for using the enhanced debugging features
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/nonNull.ts | Enhanced nonNull helper functions with required debugging parameters |
| eslint.config.mjs | Added ESLint rule to prevent importing nonNull helpers from external library |
| .github/copilot-instructions.md | Added comprehensive documentation for nonNull helper usage guidelines |
| extension.bundle.ts | Added ESLint disable comment for intentional re-export |
| Multiple source files | Updated all nonNull function calls to include debugging context |
github-project-automation
Bot
moved this from In review
to Done
in DocumentDB for VSCode: Release Plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.