fix: restore password support when new connections are created using a "connection string" feature.#247
Merged
Conversation
…a connection string
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes password support when creating new connections using connection strings by improving username validation and connection string construction. The changes ensure users must provide a valid username and that the username is properly set in the connection string even when initially empty.
Key Changes
- Added asynchronous validation to prevent empty usernames with localized error messages
- Fixed connection string construction to always set the username field (even if empty)
- Added localization support for the new validation error message
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/commands/newConnection/PromptUsernameStep.ts | Added async validation to prevent empty usernames |
| src/commands/newConnection/PromptPasswordStep.ts | Ensures username is always set when constructing connection string |
| l10n/bundle.l10n.json | Added localization entry for username validation error |
khelanmodi
approved these changes
Sep 5, 2025
github-project-automation
Bot
moved this from In review
to Done
in DocumentDB for VSCode: Release Plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user experience and validation logic when entering a username during the new connection workflow. The main changes ensure that users cannot proceed with an empty username and that appropriate error messages are displayed.
Validation and user feedback improvements:
PromptUsernameStepto prevent empty usernames and display a localized error message if the username is empty.Connection string handling:
PromptPasswordStepto ensure the username is always set (to an empty string if not provided) when constructing the connection string.…a connection string