pre release fixes#554
Merged
Merged
Conversation
The abort listener was kept active during synchronous API initialization (llmEnhancedFeatureApis, QueryInsightsApis) after the MongoClient connected. A late cancellation in that narrow window could close an already-connected client while the method continued as successful. Remove the listener right after connect() resolves to eliminate this race.
Add inline comment explaining that connectionCorrelationId retains the value from the initial connection. Cached reconnects do not emit new metadata telemetry events, so generating a new ID would be misleading rather than helpful.
The connect telemetry event emitted on tree-expansion cancellation was missing source and experience properties, making the event harder to attribute in analytics. Add source='treeExpansion' and the experience API type to match the pattern used by subclass connect events.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies small pre-release fixes focused on telemetry enrichment during connect cancellation and more robust AbortSignal handling during MongoClient connection initialization.
Changes:
- Adds additional telemetry properties (
source,experience) when a connect attempt is cancelled during tree expansion. - Adjusts AbortSignal listener cleanup timing after
MongoClient.connect()resolves and documents correlation ID behavior for cached reconnects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/tree/documentdb/ClusterItemBase.ts | Adds telemetry properties for cancelled connect attempts initiated via tree expansion. |
| src/documentdb/ClustersClient.ts | Tweaks abort-listener cleanup around connect() and clarifies correlation ID semantics for cached reconnects. |
khelanmodi
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.