fix: improve hidden index tree item visibility and menu actions#674
Open
lte-z wants to merge 2 commits into
Open
fix: improve hidden index tree item visibility and menu actions#674lte-z wants to merge 2 commits into
lte-z wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds richer context and UI cues for DocumentDB index tree items so the Hide/Unhide Index commands only appear when appropriate (e.g., not for default _id_ indexes, and toggling based on hidden state).
Changes:
- Add
index_hidden/index_defaultcontext values and show a “hidden” description for hidden indexes in the tree. - Update command
whenclauses to hide/show Hide/Unhide actions based on those context values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/tree/documentdb/IndexItem.ts | Adds contextValue tokens for default/hidden indexes and displays “hidden” in the tree item description. |
| package.json | Refines command visibility logic for Hide/Unhide Index using the new contextValue tokens. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #656
Changes
This PR improves hidden index visibility and context menu behavior in the tree view.
Tree item updates
IndexItemcontext valueshiddendescription for hidden indexes in the tree viewContext menu updates
Updated menu
whenclauses so only valid actions are shown:_id_indexes show neither actionBehavior
Hidden indexes
hiddennext to the index name in the treeRegular indexes
_id_indexScreenshots
idindexRegular and hidden indexes
Notes
createContextValue()to compose index state context segments