fix: improve delete confirmation word handling#679
Open
lte-z wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for a fallback confirmation word for “word confirmation” dialogs so destructive actions aren’t blocked by long/complex entity names.
Changes:
- Introduced
WordConfirmationOptionsandresolveConfirmationWord()to substitute a fallback word for complex/long confirmation words. - Extended
getConfirmationAsInSettings()/getConfirmationWithWordQuestion()to accept word-confirmation options. - Updated several delete commands to use a simple “delete” confirmation word (directly or via fallback).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/dialogs/getConfirmation.ts | Adds fallback word resolution and plumbs options through word-confirmation flows. |
| src/commands/index.dropIndex/dropIndex.ts | Changes the required confirmation word from the index name to the constant "delete". |
| src/commands/deleteDatabase/deleteDatabase.ts | Uses fallback "delete" for complex database IDs. |
| src/commands/deleteCollection/deleteCollection.ts | Uses fallback "delete" for complex collection names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #677
Changes
This PR improves word confirmation behavior for destructive delete operations.
Index deletion
deleteas the confirmation word when dropping an indexDatabase and collection deletion
deletewhen the resource name:[a-zA-Z]Confirmation utility
WordConfirmationOptionsfor word-confirmation fallback behaviorBehavior
Indexes
deleteShort alphabetic database and collection names
usersandordersstill prompt for the exact resource nameComplex database and collection names
test_db,order_items, and long resource names now prompt fordeleteScreenshots
verylongdatabasenameprompts fordeletecollection-nameprompts fordeleteIndex deletion prompts for
delete, even for short index namesNotes