Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
3872005
feat(jdtls): add `PomPath` to metadata
FluoriteCafe-work Sep 10, 2025
5574787
feat: MetadataManager
FluoriteCafe-work Sep 10, 2025
3988de5
feat: add command `triggerJavaUpgradeTool`
FluoriteCafe-work Sep 10, 2025
bf7eb04
feat: NotificationManager
FluoriteCafe-work Sep 10, 2025
18be55e
feat: IssueManager
FluoriteCafe-work Sep 10, 2025
560048c
feat(upgradeManager): collect issues on load and workspace folder update
FluoriteCafe-work Sep 10, 2025
0503046
feat: integrate the flow
FluoriteCafe-work Sep 10, 2025
b2406d9
feat: add context menu to open modernization tool
FluoriteCafe-work Sep 10, 2025
fa488ef
fix: only show modernization menu when related extension is installed
FluoriteCafe-work Sep 10, 2025
9fbc1c2
fix: typo
FluoriteCafe-work Sep 10, 2025
c3ee610
chore: fmt
FluoriteCafe-work Sep 10, 2025
0e998ba
feat: control reminder display by settings
FluoriteCafe-work Sep 10, 2025
3b62771
feat: don't scan when upgrade extension does not exist
FluoriteCafe-work Sep 10, 2025
9043db4
chore: make class methods static as there are no states here
FluoriteCafe-work Sep 10, 2025
06c14d9
fix: typo
FluoriteCafe-work Sep 10, 2025
1fac1f0
chore: add copyright headers
FluoriteCafe-work Sep 10, 2025
97a044a
chore: skip package dependency check when JRE version issue is found
FluoriteCafe-work Sep 11, 2025
a554cca
chore: check Settings first as it's cheaper (?)
FluoriteCafe-work Sep 11, 2025
67fba26
chore: revise fix prompts
FluoriteCafe-work Sep 11, 2025
c667fa2
chore: call `javaupgrade.gotoAgentMode` to trigger prompts
FluoriteCafe-work Sep 11, 2025
cda24ca
feat: revise notification message
FluoriteCafe-work Sep 11, 2025
5817721
fix: only trigger notification on the first issue found
FluoriteCafe-work Sep 11, 2025
f6db20c
feat: allow "Not Now" or "Don't Show Again" for notifications
FluoriteCafe-work Sep 11, 2025
4bc2e93
fix(upgradeManager): command calling
FluoriteCafe-work Sep 11, 2025
b93017d
chore: Java uses the word `runtime` instead of `engine`
FluoriteCafe-work Sep 11, 2025
2da82b0
chore: remove debug strings
FluoriteCafe-work Sep 11, 2025
802f9de
feat: support deprecated dependencies (and add Java EE as an example)
FluoriteCafe-work Sep 11, 2025
82aaf05
fix: use 21 when showing latest version
FluoriteCafe-work Sep 11, 2025
887261c
chore: string polishment
FluoriteCafe-work Sep 11, 2025
535e190
fix: fix prompt version insertion issues
FluoriteCafe-work Sep 11, 2025
6655cd8
chore: centralize JRE metadata together
FluoriteCafe-work Sep 12, 2025
cabb469
chore: rename settings `java.dependency.showUpgradeReminder` -> `java…
FluoriteCafe-work Sep 12, 2025
7c606cb
fix: only show Modernize Java Project under Java project environment
FluoriteCafe-work Sep 12, 2025
4bdc6d6
chore: `java.view.modernizeJavaProject` -> `_java.view.modernizeJavaP…
FluoriteCafe-work Sep 12, 2025
81b9905
chore: `java.view.triggerJavaUpgradeTool` -> `_java.upgrade.triggerUp…
FluoriteCafe-work Sep 12, 2025
76a8261
chore: change JRE package ID to `java:*`
FluoriteCafe-work Sep 12, 2025
56084e6
chore: centralize `LATEST_JAVA_LTS_VESRION` and `SESSION_COUNT_BEFORE…
FluoriteCafe-work Sep 12, 2025
28d2ee4
chore: `_java.upgrade.triggerUpgrade` -> `_java.upgradeWithCopilot`
FluoriteCafe-work Sep 12, 2025
2789537
chore: no need for `PomPath`
FluoriteCafe-work Sep 12, 2025
1f0a36f
fix(notificationManager): use settings to control whether to send not…
FluoriteCafe-work Sep 12, 2025
fbe2d5f
chore: split assessment part to `assessmentManager`
FluoriteCafe-work Sep 12, 2025
790a5ea
feat: use `DisplayInterface` to organize user faced presentations
FluoriteCafe-work Sep 12, 2025
1872705
chore: string improvements
FluoriteCafe-work Sep 12, 2025
e9b6917
chore: get all issues for notification
FluoriteCafe-work Sep 12, 2025
e25d0b6
feat: add telemetry
FluoriteCafe-work Sep 12, 2025
46f78a8
fix: add current version to telemetry
FluoriteCafe-work Sep 12, 2025
c2c4cf6
chore: restore formatting
FluoriteCafe-work Sep 12, 2025
1c1fef6
fix: pass `suggestedVersion` to `UpgradeIssue`
FluoriteCafe-work Sep 12, 2025
a370292
feat: update dependency data definition
FluoriteCafe-work Sep 15, 2025
03c85fb
chore: update event names
FluoriteCafe-work Sep 15, 2025
daf65c5
chore(assessmentManager): refactor
FluoriteCafe-work Sep 15, 2025
12f8a9b
chore(notificationManager): merge code to send choice
FluoriteCafe-work Sep 15, 2025
4bec023
chore: refactor method names
FluoriteCafe-work Sep 15, 2025
f7f2d29
chore: rename
FluoriteCafe-work Sep 15, 2025
6af3122
chore: rename the interface
FluoriteCafe-work Sep 15, 2025
a64a3c8
fix: stringify the telemetry
FluoriteCafe-work Sep 15, 2025
1386bfb
chore(upgradeManager): no need to check command
FluoriteCafe-work Sep 15, 2025
fa0fe9e
chore: split `getWorkspaceIssues`
FluoriteCafe-work Sep 15, 2025
5e0f4b0
chore: telemetry operation name
FluoriteCafe-work Sep 15, 2025
9fa24f9
chore: rename `java.dependency.enableDependencyDiagnostics`
FluoriteCafe-work Sep 15, 2025
1456262
chore: add `operationName` in telemetry
FluoriteCafe-work Sep 15, 2025
efdff83
chore: don't collect `failureReason`
FluoriteCafe-work Sep 15, 2025
2578194
chore: rename
FluoriteCafe-work Sep 15, 2025
731d86a
chore: don't show the commands in CP
FluoriteCafe-work Sep 15, 2025
803be9b
chore: fix lint
FluoriteCafe-work Sep 15, 2025
aea445f
feat: show reasons for the versions we choose
FluoriteCafe-work Sep 16, 2025
430f7e8
feat: update notification display UX
FluoriteCafe-work Sep 16, 2025
440e92e
chore: merge `getNowTs()`
FluoriteCafe-work Sep 16, 2025
478d871
chore(notificationManager): tweak order of `shouldShow` and `hasShown`
FluoriteCafe-work Sep 16, 2025
4397ccc
chore: `workspaceUri` -> `workspaceFolderUri`
FluoriteCafe-work Sep 16, 2025
a0abeb9
chore: lint
FluoriteCafe-work Sep 16, 2025
4d271c1
feat: add EOL date to notification
FluoriteCafe-work Sep 16, 2025
3b09680
chore: lint
FluoriteCafe-work Sep 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: show reasons for the versions we choose
  • Loading branch information
FluoriteCafe-work committed Sep 16, 2025
commit aea445f1d659877ab2aedfad664d5704c1247c72
26 changes: 21 additions & 5 deletions src/upgrade/dependency.metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,32 +10,48 @@ export const DEPENDENCY_JAVA_RUNTIME = {
"name": "Java Runtime",
"reason": UpgradeReason.JRE_TOO_OLD,
"supportedVersion": `>=${LATEST_JAVA_LTS_VESRION}`,
"suggestedVersion": String(LATEST_JAVA_LTS_VESRION),
"suggestedVersion": {
"name": String(LATEST_JAVA_LTS_VESRION),
"description": "latest LTS version",
},
} as const;

const DEPENDENCIES_TO_SCAN: DependencyCheckMetadata = {
"org.springframework.boot:*": {
"reason": UpgradeReason.END_OF_LIFE,
"name": "Spring Boot",
"supportedVersion": "2.7.x || >=3.2.x",
"suggestedVersion": "3.5",
"suggestedVersion": {
"name": "3.5",
"description": "latest stable release",
},
},
"org.springframework:*": {
"reason": UpgradeReason.END_OF_LIFE,
"name": "Spring Framework",
"supportedVersion": "5.3.x || >=6.2.x",
"suggestedVersion": "6.2"
"suggestedVersion": {
"name": "3.5",
"description": "latest stable release",
},
},
"org.springframework.security:*": {
"reason": UpgradeReason.END_OF_LIFE,
"name": "Spring Security",
"supportedVersion": "5.7.x || 5.8.x || >=6.2.x",
"suggestedVersion": "6.5"
"suggestedVersion": {
"name": "3.5",
"description": "latest stable release",
},
},
"javax:*": {
"reason": UpgradeReason.DEPRECATED,
"name": "Java EE",
"alternative": "Jakarta EE 10",
"alternative": {
"name": "Jakarta EE 10",
"description": "latest release with wide Java runtime version support",

},
},
[Upgrade.PACKAGE_ID_FOR_JAVA_RUNTIME]: DEPENDENCY_JAVA_RUNTIME,
};
Expand Down
9 changes: 5 additions & 4 deletions src/upgrade/type.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license.

export type UpgradeTarget = { name: string; description: string };
export type DependencyCheckItemBase = { name: string, reason: UpgradeReason };
export type DependencyCheckItemEol = DependencyCheckItemBase
& { reason: UpgradeReason.END_OF_LIFE | UpgradeReason.JRE_TOO_OLD, supportedVersion: string, suggestedVersion: string };
export type DependencyCheckItemDeprecated = DependencyCheckItemBase & { reason: UpgradeReason.DEPRECATED, alternative: string };
& { reason: UpgradeReason.END_OF_LIFE | UpgradeReason.JRE_TOO_OLD, supportedVersion: string, suggestedVersion: UpgradeTarget };
export type DependencyCheckItemDeprecated = DependencyCheckItemBase & { reason: UpgradeReason.DEPRECATED, alternative: UpgradeTarget };
export type DependencyCheckItem = (DependencyCheckItemEol | DependencyCheckItemDeprecated);
export type DependencyCheckMetadata = Record<string, DependencyCheckItem>;

Expand All @@ -17,10 +18,10 @@ export enum UpgradeReason {

export type UpgradeIssue = {
packageId: string;
packageDisplayName?: string;
packageDisplayName: string;
reason: UpgradeReason;
currentVersion: string;
suggestedVersion?: string;
suggestedVersion: UpgradeTarget;
};

export interface IUpgradeIssuesRenderer {
Expand Down
28 changes: 17 additions & 11 deletions src/upgrade/utility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,37 @@ import { UpgradeReason, type UpgradeIssue } from "./type";
import { Upgrade } from "../constants";

export function buildNotificationMessage(issue: UpgradeIssue): string {
const { packageId, currentVersion, suggestedVersion, packageDisplayName } = issue;
const name = packageDisplayName ?? packageId;
const { packageId, currentVersion, reason, suggestedVersion: { name: suggestedVersionName, description: suggestedVersionDescription }, packageDisplayName } = issue;

if (packageId === Upgrade.PACKAGE_ID_FOR_JAVA_RUNTIME) {
return `The current project is using an older runtime (Java ${currentVersion}). Do you want to upgrade to the latest LTS version${suggestedVersion ? ` (${suggestedVersion})` : ""}?`;
return `The current project is using an older Java runtime (${currentVersion}). Do you want to upgrade to the latest LTS version ${suggestedVersionName}?`;
}

return `The current project is using ${name} ${currentVersion}, which has reached end of life. Do you want to upgrade to ${suggestedVersion ? ` ${suggestedVersion}` : "the latest version"
}?`;
switch (reason) {
case UpgradeReason.CVE: {
return `The current project is using ${packageDisplayName} ${currentVersion}, which has CVE issues. Do you want to upgrade to ${suggestedVersionName} (${suggestedVersionDescription})?`;
}
case UpgradeReason.DEPRECATED:
case UpgradeReason.END_OF_LIFE:
default: {
return `The current project is using ${packageDisplayName} ${currentVersion}, which has reached end of life. Do you want to upgrade to ${suggestedVersionName} (${suggestedVersionDescription})?`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“which has reached end of life”
Can we be explicit about the time of "end of life"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 4d271c1.

The current project is using Spring Boot 3.1.3, which has reached end of life in 2025-06. [...]

}
}
}


export function buildFixPrompt(issue: UpgradeIssue): string {
const { packageId, packageDisplayName, reason, suggestedVersion } = issue;
const name = packageDisplayName ?? packageId;
const { packageDisplayName, reason, suggestedVersion: { name: suggestedVersionName } } = issue;

switch (reason) {
case UpgradeReason.CVE: {
return `upgrade package ${name} to ${suggestedVersion ?? "the latest version"} to address CVE issues using java upgrade tools`;
return `upgrade ${packageDisplayName} to ${suggestedVersionName} to address CVE issues using java upgrade tools`;
}
case UpgradeReason.JRE_TOO_OLD: {
return `upgrade java runtime to latest LTS version${suggestedVersion ? ` (${suggestedVersion})` : ""
} using java upgrade tools`;
return `upgrade java runtime to the latest LTS version ${suggestedVersionName} using java upgrade tools`;
}
default: {
return `upgrade package ${name} to ${suggestedVersion ?? "the latest version"} using java upgrade tools`;
return `upgrade ${packageDisplayName} to ${suggestedVersionName} using java upgrade tools`;
}
}
}
Expand Down