Enable Encryption by default + introduce HostNameInCertificate#17484
Enable Encryption by default + introduce HostNameInCertificate#17484cheenamalhotra merged 30 commits intomainfrom
Conversation
195d5d8 to
5c1e842
Compare
|
I'd prefer both the dialogs link to our aka.ms link where we will have specific documentation on VS Code connectivity. From there, we can link to more information specifically on configuring SQL Server certificates but folks will also see info on the settings file and encryption options. |
erinstellato-ms
left a comment
There was a problem hiding this comment.
I agree with Drew's comment - everything else looks great.
|
Apologies for the large amount of nit comments - I mostly left them here to point out the different types of cleanup to be on the lookout for when you're working in this repo (most of the newer styles such as async/await weren't in use when this stuff was originally made). I'll tone it down in future PRs - and feel free to just mark those as follow up items if you want. There are a couple of actual issues/comments to look at too though. |
I agree there's a lot of improvement scope in this repository, will address things that are in scope of the PR here. |
447d77e to
b3158f7
Compare
Charles-Gagnon
left a comment
There was a problem hiding this comment.
ConnectionUI has an issue you should resolve, and there's some other stuff you should look at too.
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Addressed all feedback
Bringing in Microsoft.Data.SqlClient 5.0.1 dependency with STS 4.4.0.7
Sets
EncrypttoMandatoryby default.Adds support for
HostNameInCertificateSqlConnection property.Adds welcome note for encryption behavior change (Updated)

More information redirects to: https://aka.ms/vscodemssql-connection (placeholder link for blogpost)
Enables setting

Trust Server Certificateto true with prompt for cert validation failure.Read more redirects to: https://aka.ms/vscodemssql-connection (placeholder link for blogpost)
Demo
Captures double failure scenario as well