Add auto start browser as default value - #229
Merged
Paula (paulacamargo25) merged 4 commits intoFeb 23, 2024
Merged
Conversation
Paula (paulacamargo25)
added
the
feature-request
Paula (paulacamargo25)
marked this pull request as ready for review
February 22, 2024 02:27
Bhavya U (bhavyaus)
requested changes
Feb 22, 2024
Bhavya U (bhavyaus)
left a comment
Bhavya U (bhavyaus)
left a comment
Contributor
There was a problem hiding this comment.
Blocking on the warnings in flaskLaunch.unit.test.ts. Feel free to dismiss my review with a reason if the warnings are ignorable.
Paula (paulacamargo25)
force-pushed
the
Add-autoStartBrowser-as-default-value
branch
from
February 22, 2024 19:47
c818808 to
48c916a
Compare
Contributor
Author
Thanks for the review Bhavya U (@bhavyaus), yes the warnings are ignorables. So dont worry. |
Bhavya U (bhavyaus)
previously approved these changes
Feb 22, 2024
Karthik Nadig (karthiknadig)
approved these changes
Feb 23, 2024
Paula (paulacamargo25)
added a commit
that referenced
this pull request
Feb 27, 2024
* Update debugpy version (#220) * update version of debugpy * update extension version * update version * Adding note to use pre-releases for older versions (#218) * Adding note for pre-releases for older versions * Updating note * Do not create config when esc is hit (#228) * dont continue if esc is hit * fix lint * fix tests * Add auto start browser as default value (#229) * Add autoStartBrowser * fix tests * fix lint * fix tests * Update README.md (#234) * Keep tag version and debugpy version * dont update value --------- Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.