Attach & for shell integration enabled pwsh case - #652
Merged
Conversation
Anthony Kim (anthonykim1)
requested review from
Eleanor Boyd (eleanorjboyd) and
Karthik Nadig (karthiknadig)
July 25, 2025 21:44
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
July 25, 2025 21:46
Anthony Kim (anthonykim1)
marked this pull request as draft
July 25, 2025 21:51
auto-merge was automatically disabled
July 25, 2025 21:51
Pull request was converted to draft
| } | ||
| }); | ||
|
|
||
| const shouldSurroundWithQuotes = |
Contributor
Author
There was a problem hiding this comment.
wrapping executable in double quotes after checking if there is white space.
Also checking they are not already wrapped in double quotes.
Anthony Kim (anthonykim1)
marked this pull request as ready for review
July 25, 2025 22:41
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
July 25, 2025 22:46
Eleanor Boyd (eleanorjboyd)
approved these changes
Jul 25, 2025
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python-environments
that referenced
this pull request
Jul 27, 2025
NgCuong (NguyenCuong1989)
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #649