package-lock.json bumped to lockfile version 2 (npm 7)

[jakebailey]

I pulled from main, and noticed that npm complained about the lockfile. #16130 appears to have been run via the wrong version of npm (the newer v7, versus v6), which auto-upgraded the lockfile. Node 12 (what this project uses, as that's what VS Code uses) includes npm 6. I'm thinking that this bump was a mistake; I can't locally do things without the lockfile being completely recreated, and I'm not sure that it's actually pinning dependencies anymore in the builder.

[karthiknadig]

We should revert to npm 6 format (i.e., lockfile version1)

[DonJayamanne]

Why not just upgrade to npm 7? You can isntall npm 7 with other node versions.
That's what we're doing in Jupyter extension.
I guess we should have had a separate issue to upgrade npm to 7, hence reverting does make sense to track the upgrade (I.e. i didn't realize i upgrade this lock file here - was indavertent).

[jakebailey]

CI selects Node 12, which means it's going to be using npm 6. Differing in this setup is going to cause problems. Newer versions of npm 6 can sort of attempt to handle it, but this isn't behavior I would want to rely on.

[jakebailey]

I know because we hit this in pyright/pylance, and I had to fix it. Our CI is stricter and errors in lint if npm install changes any files on disk.

For us, we're going to be skipping straight past this problem and moving to yarn 2 (where the package manager is committed to the repo, and the lockfile format isn't awful).

[karthiknadig]

In our instructions for people we ask them to install node 12 (which as Jake Bailey (@jakebailey) pointed out comes with npm 6). So we will have to change the instructions for people as well which can be confusing.