Skip to content

Ensure that wheels experiment uses the right debugger depending on control or experimental group #8460

Description

Currently only people in wheels experiment get the new debugger.

Proposed changes

These changes proposed based on spike here: #8419

  • Ensure that telemetry is generated in ptvsd Add telemetry event when debugger binaries are used ptvsd#1859 . This guarantees that we get a telemetry event saying debugger has loaded the wheels. This is true for the case where the user has manually installed ptvsd. (Telemetry 1)

  • Ensure we can use experiments for wheels: The proposal is to move source only version of ptvsd and the source with wheels version of ptvsd to separate directories. This way if users are NOT in experiment they get Group A, if they are in experiment they get Group B.

    • Move the source only version of ptvsd to: ./pythonFiles/lib/python/new_ptvsd/no_wheels/ (group A). This can be installed via .yml files.
    • Update install_ptvsd.py to install wheels to: ./pythonFiles/lib/python/new_ptvsd/wheels/ (group B)
      • In this case we need to have a telemetry event saying we have selected the wheels version of ptvsd. Since we only select it for particular cases (py 3.7 only). (Telemetry 2)
      • Update test_install_ptvsd.py to point to the Group B directory.

Telemetry 1 and Telemetry 2 should be enough to correlate that a given user in wheels experiment, got the path to the wheels version of ptvsd and python used the wheels while loading ptvsd.

Metadata

Metadata

Labels

area-debuggingbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions