Skip to content

MimeTest was failing with true jupyter #14261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 1 commit into from
Oct 5, 2020
Merged

MimeTest was failing with true jupyter #14261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions src/test/datascience/Untitled-1.ipynb
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/test/datascience/notebook.functional.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,10 @@ suite('DataScience notebook tests', () => {
);
const actualMimeType = data.hasOwnProperty(mimeType) ? mimeType : 'text/plain';
assert.ok((data as any)[actualMimeType], `${index}: Cell mime type not correct`);
verifyValue((data as any)[actualMimeType]);
verifyValue(concatMultilineString((data as any)[actualMimeType]));
}
if (text) {
verifyValue(text);
verifyValue(concatMultilineString(text as any));
}
} else if (cellType === 'markdown') {
assert.equal(cells[0].data.cell_type, cellType, `${index}: Wrong type of cell returned`);
Expand Down