Fallback to jedi when using python 2.7, <=3.5 - #15734
Merged
Karthik Nadig (karthiknadig) merged 3 commits intoMar 22, 2021
Merged
Conversation
Brett Cannon (brettcannon)
requested changes
Mar 19, 2021
Brett Cannon (brettcannon)
left a comment
Brett Cannon (brettcannon)
left a comment
Member
There was a problem hiding this comment.
Minor cleanup in dependencies, otherwise LGTM!
Codecov Report
@@ Coverage Diff @@
## main #15734 +/- ##
=======================================
Coverage 64% 65%
=======================================
Files 557 551 -6
Lines 26730 26370 -360
Branches 3887 3806 -81
=======================================
- Hits 17292 17257 -35
+ Misses 8708 8382 -326
- Partials 730 731 +1
|
Karthik Nadig (karthiknadig)
requested a review
from Brett Cannon (brettcannon)
March 19, 2021 23:23
Brett Cannon (brettcannon)
approved these changes
Mar 22, 2021
Kartik Raj (karrtikr)
approved these changes
Mar 22, 2021
Comment on lines
+236
to
+241
| if (serverType === LanguageServerType.JediLSP && interpreter && interpreter.version) { | ||
| if (interpreter.version.major < 3 || (interpreter.version.major === 3 && interpreter.version.minor < 6)) { | ||
| sendTelemetryEvent(EventName.JEDI_LANGUAGE_SERVER_FALLBACK); | ||
| serverType = LanguageServerType.Jedi; | ||
| } | ||
| } |
There was a problem hiding this comment.
We should probably mention this in JediLSP description in package.json.
Member
Author
There was a problem hiding this comment.
We don't have a description for the individual values in the LS field. May be we can change it (field type) to be better described. Although there still no consensus on how to provide enum descriptions in json.
There was a problem hiding this comment.
I see, we can skip this for now I guess.
Karthik Nadig (karthiknadig)
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Mar 22, 2021
* Fallback to jedi when using 2.7 * Address comments. * Update jedi-language-server to latest again
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Mar 23, 2021
* Fallback to jedi when using 2.7 * Address comments. * Update jedi-language-server to latest again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
jediandjedi-language-serverinstallation.jedi-language-serverto latest.jedi < 0.18for 2.7 and <= 3.5.Closes #15735
Closes #15724
Closes #15731