Fix the path where we look for LS version for telemetry - #15749
Merged
Karthik Nadig (karthiknadig) merged 2 commits intoMar 22, 2021
Conversation
Karthik Nadig (karthiknadig)
added
no-changelog
Karthik Nadig (karthiknadig)
requested review from
Jake Bailey (jakebailey) and
Kartik Raj (karrtikr)
March 22, 2021 21:38
Jake Bailey (jakebailey)
approved these changes
Mar 22, 2021
Kartik Raj (karrtikr)
approved these changes
Mar 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #15749 +/- ##
======================================
Coverage 65% 65%
======================================
Files 551 551
Lines 26348 26348
Branches 3804 3804
======================================
Hits 17236 17236
Misses 8382 8382
Partials 730 730
|
Kim-Adeline Miguel (kimadeline)
approved these changes
Mar 22, 2021
Kim-Adeline Miguel (kimadeline)
approved these changes
Mar 22, 2021
Karthik Nadig (karthiknadig)
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Mar 22, 2021
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
Mar 23, 2021
* Fix the path where we look for LS version for telemetry * Add tracing when version retreival fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15735
Closes #15724
Closes #15731