Block on displaying selected interpreter in the status bar on startup - #15971
Merged
Conversation
Kartik Raj (karrtikr)
force-pushed
the
fs
branch
2 times, most recently
from
April 15, 2021 21:02
87d2ecc to
4663fa3
Compare
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
force-pushed
the
fs
branch
from
April 28, 2021 21:08
4bc77b6 to
3d15088
Compare
Kartik Raj (karrtikr)
marked this pull request as ready for review
April 28, 2021 21:17
github-actions
Bot
requested review from
Karthik Nadig (karthiknadig) and
Kim-Adeline Miguel (kimadeline)
April 28, 2021 21:18
Kartik Raj (karrtikr)
force-pushed
the
fs
branch
from
April 28, 2021 21:31
3d15088 to
5c88c51
Compare
Karthik Nadig (karthiknadig)
approved these changes
Apr 29, 2021
Member
|
Kartik Raj (@karrtikr) can you rebase with main. The Sonar issue should be fixed in main. |
Kim-Adeline Miguel (kimadeline)
approved these changes
Apr 29, 2021
|
|
||
| serviceManager.get<ICodeExecutionManager>(ICodeExecutionManager).registerCommands(); | ||
|
|
||
| interpreterManager |
There was a problem hiding this comment.
Were there any issues caused by the absence of await here?
Author
There was a problem hiding this comment.
The extension would finish loading (Python extension loading... text would disappear) but the user won't see the selected interpreter in the status bar, which might be confusing.
This improves things a bit, but it might increase extension activation time we record in telemetry.
Kartik Raj (karrtikr)
force-pushed
the
fs
branch
from
April 29, 2021 20:41
5c88c51 to
4a4ccee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-python-internalbacklog/issues/149 closes https://github.com/microsoft/vscode-python-internalbacklog/issues/156
This means we need to make the process of getting active interpreter faster.