Add Python: Refresh TensorBoard command - #16068
Conversation
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
No tests to update/add?
|
Kartik Raj (@karrtikr) I don't think it's possible to write a test to verify that this works because we can't inspect the iframed contents. It would be possible to confirm that the TensorBoardSession class refresh method is called when the command is executed, but that's about it. |
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
I think it might be possible if you're able to stub window.createWebviewPanel and verify the contents of webviewPanel.webview.html. I leave it upto you.
|
Kartik Raj (@karrtikr) sorry no, I meant that it's not possible to verify the contents of the iframe that we create, because that has a cross-origin source (before rewriting, it's a localhost URL). The HTML will only give us the iframe element and the attributes, it won't give us what's actually rendered on the page. |
|
Joyce Er (@joyceerhl) I see. Is it useful to atleast verify the the HTML in the test? If not, skipping tests is fine here I think. |
|
Yeah the HTML is just going to be whatever we set. Not sure that's worth validating with a test. |
For #16053