Remove default pylint when using jedi - #16074
Merged
Karthik Nadig (karthiknadig) merged 6 commits intoMay 4, 2021
Merged
Conversation
Karthik Nadig (karthiknadig)
force-pushed
the
remove-default-pylint
branch
from
April 29, 2021 03:32
b9a5c82 to
1fc8d60
Compare
Karthik Nadig (karthiknadig)
added
the
skip package*.json
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
May 3, 2021 22:38
github-actions
Bot
requested review from
Kartik Raj (karrtikr) and
Kim-Adeline Miguel (kimadeline)
May 3, 2021 22:38
Kartik Raj (karrtikr)
approved these changes
May 3, 2021
| "description": "Path to Pylint, you can use a custom version of pylint by modifying this setting to include the full path.", | ||
| "scope": "resource" | ||
| }, | ||
| "python.linting.pylintUseMinimalCheckers": { |
There was a problem hiding this comment.
Not sure about removal of this setting, but I guess it was introduced we wanted minimal checkers with pylint by default?
Member
Author
There was a problem hiding this comment.
it was a substitute for the syntax checking that we have with JediLSP now. Previously we did not have that with jedi so we used pylint to get this. Now this is no longer needed and is part of the deprecation process.
Kim-Adeline Miguel (kimadeline)
approved these changes
May 4, 2021
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
May 10, 2021
* Remove default pylint when using jedi * Remove pylint minimal checkers * Remove more pylint config * Restore missed configuration file names * More linting clean up * Fix tests
Karthik Nadig (karthiknadig)
added a commit
that referenced
this pull request
May 12, 2021
* Remove default pylint when using jedi * Remove pylint minimal checkers * Remove more pylint config * Restore missed configuration file names * More linting clean up * Fix tests
Karthik Nadig (karthiknadig)
added a commit
to karthiknadig/vscode-python
that referenced
this pull request
Aug 6, 2021
* Remove default pylint when using jedi * Remove pylint minimal checkers * Remove more pylint config * Restore missed configuration file names * More linting clean up * Fix tests
Kim-Adeline Miguel (kimadeline)
pushed a commit
that referenced
this pull request
Sep 16, 2021
* Remove ctags (#16066) * Remove rope (#16064) * Remove default pylint when using jedi (#16074) * Remove default pylint when using jedi * Remove pylint minimal checkers * Remove more pylint config * Restore missed configuration file names * More linting clean up * Fix tests * Remove unused files and update branch (#16128) * Add the 'security-events' permission to the CodeQL workflow (#16071) * Delete misc files we don't need anymore Co-authored-by: Brett Cannon <brett@python.org> * Rebase with main * Update news items. * Remove unused telemetry * Test build workflow * Remove ropeproject from repo settings * Remove workspace symbols * Update .eslintignore * Remove testing of build workflow * Remove unused symbolProvider.py Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Kim-Adeline Miguel <kimiguel@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.