Correct the vsix artifact name to be uploaded - #16140
Merged
Merged
Conversation
Kartik Raj (karrtikr)
added
no-changelog
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
marked this pull request as ready for review
May 4, 2021 22:17
Kartik Raj (karrtikr)
requested review from
Karthik Nadig (karthiknadig),
Kim-Adeline Miguel (kimadeline) and
Paula (paulacamargo25)
May 4, 2021 22:26
Karthik Nadig (karthiknadig)
approved these changes
May 4, 2021
Kim-Adeline Miguel (kimadeline)
approved these changes
May 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-python-internalbacklog/issues/196
See https://github.com/microsoft/vscode-python/actions/runs/811168374, The artifact uploaded is named
$ {{ steps.vsix_names.outputs.vsix_artifact_name }}instead ofms-python-insiders-vsix. That is probably because of the space character after$.I expect this to fix the smoke tests.