Test UI update and deprecations by karthiknadig · Pull Request #16769 · microsoft/vscode-python

Karthik Nadig (karthiknadig) · 2021-07-23T05:42:22Z

Things in this PR:

Switch extension to use the new Test UI API.
Removes all the old commands for testing in favor of commands from VS Code.
Removes support for Nose test framework.
Removes dependency of tests on language server.

Closes #15750 Using new Test UI from VS code:

Closes #10898 Uses VS Code API for over code lenses

Closes #16371 Remove nose test support.

Closes #1654
Closes #2382
Closes #2644
Closes #2660
Closes #2790
Closes #3062
Closes #3591
Closes #3652
Closes #4469
Closes #4848
Closes #5347
Closes #5417
Closes #5791
Closes #5889
Closes #6787
Closes #7150
Closes #7443
Closes #7870
Closes #8405
Closes #8448
Closes #8675
Closes #8761
Closes #8836
Closes #9026
Closes #9402
Closes #9640
Closes #9854
Closes #10898
Closes #10972
Closes #11864
Closes #11866
Closes #12043
Closes #12218
Closes #12403
Closes #12995
Closes #13147
Closes #13285
Closes #13713
Closes #13916
Closes #15260
Closes #15736
Closes #16371
Closes #16475

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Richard Wheeler (quaesitor-scientiam) · 2021-11-30T15:40:55Z

Has this fix made it into a release? I am experiencing same kind problem mentioned in comments and would like to get it fixed.

Thanks

Karthik Nadig (karthiknadig) · 2021-11-30T18:40:33Z

Richard Wheeler (@quaesitor-scientiam) This was in 2021.09 release.

Richard Wheeler (quaesitor-scientiam) · 2021-11-30T18:41:39Z

Thanks, had a hard time trying to figure that out.

Richard Wheeler (quaesitor-scientiam) · 2021-11-30T18:45:53Z

One more question since this is vscode-python how does it relate to VSCode releases? Need to able to management which release of VSCode to get and approve.

Karthik Nadig (karthiknadig) · 2021-11-30T19:02:25Z

Richard Wheeler (@quaesitor-scientiam) They are unrelated. But since the extension depends on the features exposed by VS Code, we sometimes require a minimum version. For the latest version of the python extension (v2021.11.*), the minimum VS Code version needed is v1.61.0.

This is set here

vscode-python/package.json

Line 41 in 4c4be47

"vscode": "^1.61.0"

Richard Wheeler (quaesitor-scientiam) · 2021-11-30T19:03:13Z

Thanks again for the quick reply

github-actions Bot requested a review from Kartik Raj (karrtikr) July 23, 2021 05:42

github-actions Bot assigned Karthik Nadig (karthiknadig) Jul 23, 2021

github-actions Bot requested a review from Kim-Adeline Miguel (kimadeline) July 23, 2021 05:42

Karthik Nadig (karthiknadig) added the skip package*.json package.json and package-lock.json don't both need updating label Jul 23, 2021

Karthik Nadig (karthiknadig) mentioned this pull request Jul 26, 2021

Test dicovery doesn't provide feedback on failure #16786

Closed

Kartik Raj (karrtikr) reviewed Jul 26, 2021

View reviewed changes

Comment thread src/client/testing/testController/unittest/unittestController.ts

Comment thread src/client/testing/testController/common/types.ts

Comment thread src/client/testing/testController/controller.ts Outdated

Comment thread src/client/testing/testController/controller.ts Outdated

Karthik Nadig (karthiknadig) force-pushed the new-test-ui branch from d48f08c to d115600 Compare July 26, 2021 22:12

Kim-Adeline Miguel (kimadeline) reviewed Jul 26, 2021

View reviewed changes

Comment thread src/client/common/utils/delayTrigger.ts Outdated

Comment thread src/client/testing/main.ts

Comment thread src/client/common/utils/delayTrigger.ts Outdated

Comment thread package.json Outdated

Comment thread src/client/common/utils/delayTrigger.ts

Kartik Raj (karrtikr) reviewed Jul 26, 2021

View reviewed changes

Comment thread src/client/testing/main.ts Outdated

Comment thread src/client/testing/testController/controller.ts Outdated

Comment thread src/client/testing/testController/controller.ts

Karthik Nadig (karthiknadig) force-pushed the new-test-ui branch 2 times, most recently from 1aaa6bf to b1f1ae1 Compare July 28, 2021 19:07

Kartik Raj (karrtikr) mentioned this pull request Jul 28, 2021

Unit tests aren't discovered in sub-folders #11969

Closed

This was referenced Jul 29, 2021

Please provide ability to search test names in discovered tests #8836

Closed

Add a command for displaying the test explorer #9026

Closed

This was referenced Jul 29, 2021

Test code lenses do not disappear even after disabling the unit tests feature #1654

Closed

Code lens for a test class run under unittest doesn't show overall results for methods #2382

Closed

Karthik Nadig (karthiknadig) mentioned this pull request Jul 29, 2021

Make "run all tests" icon gray instead of green #9402

Closed

Kim-Adeline Miguel (kimadeline) mentioned this pull request Jul 29, 2021

Testing code lens do not appear on initial activation of testing support #2644

Closed

Karthik Nadig (karthiknadig) mentioned this pull request Jul 29, 2021

Test failure should not be reported as a compile error #9640

Closed

This was referenced Jul 29, 2021

With unittest Enabled: No tests ran, please check the configuration settings for the tests. #2660

Closed

Run Test | Debug Test disappear on save, then re-appear when tabbing on/off the file. #2790

Closed

Luciana Abud (luabud) mentioned this pull request Jul 29, 2021

Add shortcut to run the current test (at cursor position) #12218

Closed

Kim-Adeline Miguel (kimadeline) mentioned this pull request Jul 29, 2021

Code lenses for tests not showing up when test is defined on line 1 #3062

Closed

Luciana Abud (luabud) mentioned this pull request Jul 29, 2021

Running test fails trying to access non-existing file #12403

Closed

Kim-Adeline Miguel (kimadeline) mentioned this pull request Jul 29, 2021

command 'python.runtests' not found #3591

Closed

Karthik Nadig (karthiknadig) mentioned this pull request Jul 29, 2021

Option to disable "run test | debug test" links #10898

Closed

Kim-Adeline Miguel (kimadeline) mentioned this pull request Jul 29, 2021

Run set of tests #3652

Closed

This was referenced Jul 29, 2021

Code lenses don't work after opening files from different projects in workspace #12995

Closed

Run all tests in a multi-root workspace without prompting #13147

Closed

Kartik Raj (karrtikr) mentioned this pull request Jul 29, 2021

Navigation to code doesn't work with parameterized tests #4469

Closed

Karthik Nadig (karthiknadig) and others added 13 commits August 2, 2021 14:36

Adding code review suggestions

4a23685

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Fix package json encoding issue

9fd86ff

Fix bad package.json merge

c07318f

Fix issues with multi-root workspace runs

1be740e

Tweak multi-root support and failed test reruns

31f0b5a

Fix package json encoding

1a8799e

Fix linting

791b4e9

Add refresh and run failed icons

0d4d1f2

Trigger discovery on settings change, and show discovery errors

7a2346e

Fix encoding from windows-1252 to utf-8

d48f6a1

Better messaging when pytest is not installed

328261b

Improve handling of failure expected and pass unexpected

2c05808

Add news items

4c475a6

Karthik Nadig (karthiknadig) force-pushed the new-test-ui branch from 5a780ff to 4c475a6 Compare August 2, 2021 21:38

Add more news items.

ae249d0

Karthik Nadig (karthiknadig) merged commit a9a279b into microsoft:main Aug 5, 2021

Karthik Nadig (karthiknadig) deleted the new-test-ui branch August 5, 2021 21:45

This was referenced Aug 6, 2021

Improve logging for cases where test adapter fails with file (python) not found #10233

Closed

Fail symbol for passed test case in VS Code sidebar #16715

Closed

Using a different cwd and test path argument to pytest breaks test annotations #3029

Closed

This was referenced Aug 11, 2021

Show unittest.subTest failures in the Test Explorer #15271

Closed

Rewrite test discovery and execution code #16936

Closed

Diego Alloza González (sralloza) mentioned this pull request Dec 22, 2021

Testing always raises "Unable to read file" #10658

Closed

red8888 mentioned this pull request Dec 22, 2022

Rerun last test was never added? #20423

Closed

Navigation Menu

Uh oh!

Test UI update and deprecations - #16769

Test UI update and deprecations#16769
Karthik Nadig (karthiknadig) merged 39 commits into
microsoft:mainfrom
karthiknadig:new-test-ui

Karthik Nadig (karthiknadig) commented Jul 23, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021

Uh oh!

Karthik Nadig (karthiknadig) commented Nov 30, 2021

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021 •

edited

Loading

Uh oh!

Karthik Nadig (karthiknadig) commented Nov 30, 2021

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Karthik Nadig (karthiknadig) commented Jul 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021

Uh oh!

Karthik Nadig (karthiknadig) commented Nov 30, 2021

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Karthik Nadig (karthiknadig) commented Nov 30, 2021

Uh oh!

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Karthik Nadig (karthiknadig) commented Jul 23, 2021 •

edited

Loading

Richard Wheeler (quaesitor-scientiam) commented Nov 30, 2021 •

edited

Loading