Do not query to get all interpreters where it's not needed in the extension code - #17030
Merged
Kartik Raj (karrtikr) merged 7 commits intoAug 23, 2021
Merged
Conversation
Kartik Raj (karrtikr)
force-pushed
the
fixextensiondiscoery
branch
2 times, most recently
from
August 19, 2021 04:44
8a3cfe5 to
a7615cd
Compare
|
|
||
| public async getSuggestions(resource: Resource, ignoreCache?: boolean): Promise<IInterpreterQuickPickItem[]> { | ||
| const interpreters = await this.interpreterManager.getInterpreters(resource, { | ||
| const interpreters = await this.interpreterManager.getAllInterpreters(resource, { |
There was a problem hiding this comment.
Will be fixed to use getInterpreters() correctly in #17043.
Kartik Raj (karrtikr)
force-pushed
the
fixextensiondiscoery
branch
from
August 20, 2021 22:58
26c3eab to
9ef3352
Compare
Kartik Raj (karrtikr)
force-pushed
the
fixextensiondiscoery
branch
from
August 20, 2021 23:06
8772a91 to
23365af
Compare
Kartik Raj (karrtikr)
changed the title
getInterpreters() correctly
Kartik Raj (karrtikr)
marked this pull request as ready for review
August 20, 2021 23:11
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
Author
There was a problem hiding this comment.
I'm merging this as it's needed for the next item, still feel free to let me know of any changes I need to make.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/microsoft/vscode-python-internalbacklog/issues/369