Skip to content

Only activate language servers when running in virtual workspaces - #17519

Merged
Kartik Raj (karrtikr) merged 18 commits into
microsoft:mainfrom
karrtikr:pylancevirtualt
Nov 16, 2021
Merged

Only activate language servers when running in virtual workspaces#17519
Kartik Raj (karrtikr) merged 18 commits into
microsoft:mainfrom
karrtikr:pylancevirtualt

Conversation

@karrtikr

@karrtikr Kartik Raj (karrtikr) commented Sep 25, 2021 •
edited
Loading

Copy link
Copy Markdown

Closes #17519

@karrtikr Kartik Raj (karrtikr) added the skip package*.json package.json and package-lock.json don't both need updating label Sep 25, 2021
@karrtikr
Kartik Raj (karrtikr) marked this pull request as draft September 25, 2021 00:17
@karrtikr Kartik Raj (karrtikr) changed the title Only activate Pylance when running in virtual workspaces Only activate language servers when running in virtual workspaces Nov 9, 2021
karrtikr
Kartik Raj (karrtikr) commented Nov 10, 2021
View reviewed changes
Comment thread src/client/activation/common/analysisOptions.ts Outdated
karrtikr
Kartik Raj (karrtikr) commented Nov 11, 2021
View reviewed changes
Comment thread src/client/common/constants.ts Outdated
karrtikr
Kartik Raj (karrtikr) commented Nov 11, 2021
View reviewed changes
Comment thread src/client/activation/common/analysisOptions.ts
Comment on lines 57 to 59
protected getDocumentFilters(_workspaceFolder?: WorkspaceFolder): DocumentFilter[] {
return PYTHON;
return this.workspace.isVirtualWorkspace ? [{ language: PYTHON_LANGUAGE }] : PYTHON;
}

@karrtikr Kartik Raj (karrtikr) Nov 11, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support all virtual workspaces schemes.

@karrtikr
Kartik Raj (karrtikr) marked this pull request as ready for review November 11, 2021 17:48
jakebailey
Jake Bailey (jakebailey) reviewed Nov 11, 2021
View reviewed changes
Comment thread package.json Outdated
jakebailey
Jake Bailey (jakebailey) reviewed Nov 11, 2021
View reviewed changes
Comment thread src/client/activation/activationManager.ts Outdated
@jakebailey

Jake Bailey (jakebailey) commented Nov 11, 2021

Copy link
Copy Markdown
Member

For this, is there any reason to block interpreter access in virtual? I think it would be valid to have a local venv that you source type information from during the analysis; Pylance will fall back to calling python from $PATH if we don't have interpreter access (only in untrusted mode are we not running python).

@karrtikr

Kartik Raj (karrtikr) commented Nov 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Only reason is we wanted to start with the minimalistic features to make Pylance work 😄

For this, is there any reason to block interpreter access in virtual?

I think Pylance still does have access to the current interpreter, we only don't allow the user to change it. The ideal solution would be to just activate "interpreter" component along with language servers, I'll see if I can do that in this PR.

@karrtikr
Kartik Raj (karrtikr) marked this pull request as draft November 12, 2021 12:11
@karrtikr

Kartik Raj (karrtikr) commented Nov 12, 2021

Copy link
Copy Markdown
Author

Done, please have a look again, thanks!

@karrtikr
Kartik Raj (karrtikr) marked this pull request as ready for review November 12, 2021 13:31
karrtikr
Kartik Raj (karrtikr) commented Nov 12, 2021
View reviewed changes
Comment thread src/client/activation/types.ts Outdated
Comment thread src/client/activation/types.ts Outdated
@karrtikr Kartik Raj (karrtikr) mentioned this pull request Nov 12, 2021
Merged
@jakebailey

Jake Bailey (jakebailey) commented Nov 12, 2021

Copy link
Copy Markdown
Member

LS stuff seems fine to me, but since I'm leaving (and will be gone for two weeks on vacation), I think it'd be best for someone else to give this a try too.

@karrtikr

Kartik Raj (karrtikr) commented Nov 15, 2021

Copy link
Copy Markdown
Author

Ping Karthik Nadig (@karthiknadig)

@karrtikr Kartik Raj (karrtikr) added this to the November 2021 milestone Nov 15, 2021
@karrtikr
Kartik Raj (karrtikr) merged commit d4644dc into microsoft:main Nov 16, 2021
@karrtikr
Kartik Raj (karrtikr) deleted the pylancevirtualt branch November 16, 2021 13:10
Wes McKinney (wesm) pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
Kartik Raj @wesm
Only activate language servers when running in virtual workspaces (mi…
2642670 
…crosoft/vscode-python#17519)

* Only activate Pylance when running in virtual workspaces

* News entry

* Trigger intelliSense analysis for all schemes of python code

* Also support Jedi in virtual workspaces

* Rebase with main

* Oops

* Only support known virtual workspace scheme

* Look into all python schemes when in a virtual workspace

* Fix some tests

* Fix mistake

* Do not register Jupyter hooks when using virtual workspaces

* Nit

* Only activate interpreter and language server component when in a virtual workspace

* Make component id a mandatory field in extension activation services

* Refactor

* Use supported workspace types instead of component id

* Fix lint

* Code reviwes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luabud Luciana Abud (luabud) luabud left review comments
@karthiknadig Karthik Nadig (karthiknadig) karthiknadig approved these changes
@jakebailey Jake Bailey (jakebailey) Awaiting requested review from jakebailey

Assignees

@karrtikr Kartik Raj (karrtikr)

Labels

skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Milestone

November 2021

Development

Successfully merging this pull request may close these issues.

4 participants

@karrtikr @jakebailey @karthiknadig @luabud