Don't add cwd argument when running all tests - #17978
Merged
Karthik Nadig (karthiknadig) merged 1 commit intoNov 16, 2021
Merged
Conversation
Karthik Nadig (karthiknadig)
self-requested a review
November 9, 2021 16:56
Karthik Nadig (karthiknadig)
approved these changes
Nov 15, 2021
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17622 and #17898, attn: Karthik Nadig (@karthiknadig).
I tested this using my example workspace with
"python.testing.cwd"set to a sub-directory, andtestpathsinpytest.iniset to a sub-directory of that.Before this change, running all tests yields:
This is because the
cwdis appended as an argument, which causes pytest to ignoretestpaths, which causes it to collect tests that it shouldn't, causing a collection error.With this change, running all tests yields:
Note that
cwdis no longer an argument.It looks
cwddefaults toworkspaceFolder.fsPath, so this seems like a safe change.