Add step to create Python file and modify svg for interpreter selection by luabud · Pull Request #18289 · microsoft/vscode-python

Luciana Abud (luabud) · 2022-01-13T23:00:21Z

The svg modification is just temporarily until we decide where we will end up placing the Python info on the status bar

…on (temporarily)

Luciana Abud (luabud) · 2022-01-13T23:04:11Z

JFYI @misolori -- I edited (and potentially butchered) one of the SVGs but that's just temporarily 😅 we are going to try out moving the status bar item to the right in an experiment (more info here: #18283), so I figured it was worth hiding the status bar from the interpreter selection SVG in the mean time to not confuse users.

Kim-Adeline Miguel (kimadeline)

Do you have a screenshot of what the new SVG looks like?

Kim-Adeline Miguel (kimadeline) · 2022-01-13T23:44:13Z

                        "id": "python.runAndDebug",
                        "title": "Run and debug your Python file",
-                        "description": "[Open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n  \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",
+                        "description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n  \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",


I don't think this change adds anything to the step. If you want to keep it, I would suggest the following:

Suggested change

"description": "If you haven't already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",

"description": "If you haven't done so already, [open](command:toSide:workbench.action.files.openFile) or [create](command:toSide:welcome.showNewFileEntries) a Python file - make sure to save it as \".py\". \n Click on the play button on the top right of the editor, or press F5 when on the file and select \"Python File\" to run with the debugger. \n \n[Learn more](https://code.visualstudio.com/docs/python/python-tutorial#_run-hello-world)",

Luciana Abud (luabud) · 2022-01-14T00:08:23Z

Screenshots

Light theme:

Dark theme:

High contrast theme:

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Luciana Abud (luabud) · 2022-01-14T01:28:50Z

Kim-Adeline Miguel (@kimadeline) thank you so much for the review! I agree with you regarding the "if you haven't done so" bit -- it was unnecessary so I just removed it 😁

Co-authored-by: Kartik Raj <karraj@microsoft.com>

…luabud/vscode-python into createpythonfilestepwalkthrough

…ions from run and debug tile

Luciana Abud (luabud) · 2022-01-17T23:06:42Z

Thanks for the review and feedback Kartik Raj (@karrtikr)! I added a tip to include the select interpreter command, and removed the "open or create" actions/links from the "run and debug" tile, so now they are just in the "create file" step. I ended up not using the pythonInterpreterInfoUnpinned context though, because I figured that could be "flickerish" situations where the tile would show up or disappear when the flight information is updated 🤔

Luciana Abud (luabud) · 2022-01-17T23:07:57Z

Kartik Raj (karrtikr)

LGTM

Co-authored-by: Kartik Raj <karraj@microsoft.com>

…on (microsoft/vscode-python#18289) * Add step to create Python file and modify svg for interpreter selection (temporarily) * Apply suggestions from code review Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> * Remove unnecessary wording * Remove unnecessary wording * Apply suggestions from code review Co-authored-by: Kartik Raj <karraj@microsoft.com> * Add select interpreter command tip and remove open or create instructions from run and debug tile * Fix typo Co-authored-by: Kartik Raj <karraj@microsoft.com> * Run prettier Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Kartik Raj <karraj@microsoft.com>

Add step to create Python file and modify svg for interpreter selecti…

9f201de

…on (temporarily)

Luciana Abud (luabud) added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Jan 13, 2022

Luciana Abud (luabud) requested review from Brett Cannon (brettcannon), Kartik Raj (karrtikr), Karthik Nadig (karthiknadig) and Kim-Adeline Miguel (kimadeline) January 13, 2022 23:00

github-actions Bot assigned Luciana Abud (luabud) Jan 13, 2022

Kim-Adeline Miguel (kimadeline) reviewed Jan 13, 2022

View reviewed changes

Kim-Adeline Miguel (kimadeline) approved these changes Jan 14, 2022

View reviewed changes

Luciana Abud (luabud) and others added 3 commits January 13, 2022 17:24

Apply suggestions from code review

08802d0

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>

Remove unnecessary wording

9a64a96

Remove unnecessary wording

a3d6ff6

Karthik Nadig (karthiknadig) approved these changes Jan 14, 2022

View reviewed changes

Kartik Raj (karrtikr) reviewed Jan 14, 2022

View reviewed changes

Comment thread package.json Outdated

Comment thread package.json Outdated

Comment thread package.json

Comment thread package.json Outdated

Brett Cannon (brettcannon) approved these changes Jan 14, 2022

View reviewed changes

Luciana Abud (luabud) and others added 3 commits January 17, 2022 14:30

Apply suggestions from code review

f4124ce

Co-authored-by: Kartik Raj <karraj@microsoft.com>

Merge branch 'createpythonfilestepwalkthrough' of https://github.com/…

76a627c

…luabud/vscode-python into createpythonfilestepwalkthrough

Add select interpreter command tip and remove open or create instruct…

c24c6ea

…ions from run and debug tile

Kartik Raj (karrtikr) approved these changes Jan 18, 2022

View reviewed changes

Comment thread package.json Outdated

Luciana Abud (luabud) and others added 2 commits January 18, 2022 09:18

Fix typo

359cb94

Co-authored-by: Kartik Raj <karraj@microsoft.com>

Run prettier

857fa9b

Luciana Abud (luabud) merged commit 2c75b7d into microsoft:main Jan 19, 2022

Navigation Menu

Uh oh!

Add step to create Python file and modify svg for interpreter selection - #18289

Add step to create Python file and modify svg for interpreter selection#18289
Luciana Abud (luabud) merged 9 commits into
microsoft:mainfrom
luabud:createpythonfilestepwalkthrough

Luciana Abud (luabud) commented Jan 13, 2022 •

edited by karrtikr

Loading

Uh oh!

Luciana Abud (luabud) commented Jan 13, 2022

Uh oh!

Kim-Adeline Miguel (kimadeline) left a comment

Uh oh!

Uh oh!

Kim-Adeline Miguel (kimadeline) Jan 13, 2022

Uh oh!

Luciana Abud (luabud) commented Jan 14, 2022 •

edited

Loading

Uh oh!

Luciana Abud (luabud) commented Jan 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Luciana Abud (luabud) commented Jan 17, 2022

Uh oh!

Luciana Abud (luabud) commented Jan 17, 2022

Uh oh!

Kartik Raj (karrtikr) left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Luciana Abud (luabud) commented Jan 13, 2022 • edited by karrtikr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Luciana Abud (luabud) commented Jan 13, 2022

Uh oh!

Kim-Adeline Miguel (kimadeline) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kim-Adeline Miguel (kimadeline) Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

Luciana Abud (luabud) commented Jan 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Uh oh!

Luciana Abud (luabud) commented Jan 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Luciana Abud (luabud) commented Jan 17, 2022

Uh oh!

Luciana Abud (luabud) commented Jan 17, 2022

Uh oh!

Kartik Raj (karrtikr) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Luciana Abud (luabud) commented Jan 13, 2022 •

edited by karrtikr

Loading

Luciana Abud (luabud) commented Jan 14, 2022 •

edited

Loading