Fix rename refactor unit tests - #1955
Merged
Don Jayamanne (DonJayamanne) merged 4 commits intoJun 14, 2018
Merged
Conversation
Derek Keeler (d3r3kk)
approved these changes
Jun 13, 2018
| @@ -47,7 +47,7 @@ suite('Refactor Rename', () => { | |||
|
|
|||
| test('Rename function in source without a trailing empty line', async () => { | |||
There was a problem hiding this comment.
Fails in Windows tests, perhaps because EOLUsedByRope in Windows is the dreaded \r\n?
After that is fixed I say good!
There was a problem hiding this comment.
This is just rope using different separators. Looks like its inconsistent. I assumed it was using \n throughout, guess I was wrong.
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
+ Coverage 74.48% 74.56% +0.08%
==========================================
Files 285 285
Lines 13359 13359
Branches 2390 2390
==========================================
+ Hits 9950 9961 +11
+ Misses 3271 3260 -11
Partials 138 138
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1953
This pull request: