Expose interpreter quickpick API with filtering - #19839
Merged
Kartik Raj (karrtikr) merged 5 commits intoSep 15, 2022
Merged
Conversation
added 2 commits
September 14, 2022 16:15
Kartik Raj (karrtikr)
force-pushed
the
interpreterquickpick
branch
from
September 14, 2022 23:25
d2a671d to
d78034a
Compare
| serviceManager.addSingleton<IExtensionSingleActivationService>( | ||
| IExtensionSingleActivationService, | ||
| SetInterpreterCommand, | ||
| ); | ||
| serviceManager.addSingleton(IInterpreterQuickPick, SetInterpreterCommand); |
There was a problem hiding this comment.
I would like to have used the same SetInterpreterCommand object for both these interfaces but I'm not quite sure how to do that. Used
serviceManager.addBinding(IInterpreterQuickPick, IExtensionSingleActivationService)
But that still seems to create a new instance.
Kartik Raj (karrtikr)
marked this pull request as ready for review
September 14, 2022 23:34
Kartik Raj (karrtikr)
marked this pull request as draft
September 14, 2022 23:35
Kartik Raj (karrtikr)
force-pushed
the
interpreterquickpick
branch
from
September 14, 2022 23:39
e642178 to
c41a44b
Compare
Kartik Raj (karrtikr)
marked this pull request as ready for review
September 14, 2022 23:39
Karthik Nadig (karthiknadig)
approved these changes
Sep 15, 2022
34 tasks
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.