Add cancellation token support and link to logs. - #19882
Merged
Karthik Nadig (karthiknadig) merged 2 commits intoSep 26, 2022
Merged
Conversation
Karthik Nadig (karthiknadig)
requested a review
from Courtney Webster (cwebster-99)
September 26, 2022 19:13
Karthik Nadig (karthiknadig)
added
the
bug
Member
Author
|
Courtney Webster (@cwebster-99) Do you think should say
We can't add a button for this yet, in this progress notification. |
Member
I prefer "show logs" as it is more descriptive of the user action. |
Courtney Webster (cwebster-99)
approved these changes
Sep 26, 2022
Courtney Webster (cwebster-99)
left a comment
Courtney Webster (cwebster-99)
left a comment
Member
There was a problem hiding this comment.
Looks good! I like the "show logs" over "logs" in the prompt box.
Karthik Nadig (karthiknadig)
requested a review
from Eleanor Boyd (eleanorjboyd)
September 26, 2022 19:34
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
September 26, 2022 19:35
Eleanor Boyd (eleanorjboyd)
approved these changes
Sep 26, 2022
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19879