Removed ILanguageServer no longer used. - #19921
Merged
Heejae Chang (heejaechang) merged 4 commits intoSep 29, 2022
Merged
Conversation
Heejae Chang (heejaechang)
added
no-changelog
Karthik Nadig (karthiknadig)
requested review from
Kartik Raj (karrtikr) and
Karthik Nadig (karthiknadig)
September 29, 2022 20:29
Kartik Raj (karrtikr)
removed their request for review
September 29, 2022 20:30
Kartik Raj (karrtikr)
self-requested a review
September 29, 2022 21:12
Kartik Raj (karrtikr)
approved these changes
Sep 29, 2022
Author
|
thank you |
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
I am removing ILanguageServer and all interfaces/types existed around it since it seems it is no longer used. ... it looks like ILanguageServer used to be used for old jupyter (https://github.com/microsoft/vscode-python/blob/main/src/client/jupyter/jupyterIntegration.ts#L146) but it no longer used by jupyter anymore (https://github.com/microsoft/vscode-jupyter/blob/70dc27d55c95cb81bfd32a6505b7fb357bfe624e/src/platform/api/types.ts#L74). this PR (microsoft/vscode-jupyter#10889) removed it from jupyter since it is not used. but it is never removed from python extension. ... I am doing this as a part of on-going client move work since we do not want to expose ILanguageServer to pass to jupyter extension unless it is required.
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
I am removing ILanguageServer and all interfaces/types existed around it since it seems it is no longer used. ... it looks like ILanguageServer used to be used for old jupyter (https://github.com/microsoft/vscode-python/blob/main/src/client/jupyter/jupyterIntegration.ts#L146) but it no longer used by jupyter anymore (https://github.com/microsoft/vscode-jupyter/blob/70dc27d55c95cb81bfd32a6505b7fb357bfe624e/src/platform/api/types.ts#L74). this PR (microsoft/vscode-jupyter#10889) removed it from jupyter since it is not used. but it is never removed from python extension. ... I am doing this as a part of on-going client move work since we do not want to expose ILanguageServer to pass to jupyter extension unless it is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am removing ILanguageServer and all interfaces/types existed around it since it seems it is no longer used.
...
it looks like ILanguageServer used to be used for old jupyter (https://github.com/microsoft/vscode-python/blob/main/src/client/jupyter/jupyterIntegration.ts#L146) but it no longer used by jupyter anymore (https://github.com/microsoft/vscode-jupyter/blob/70dc27d55c95cb81bfd32a6505b7fb357bfe624e/src/platform/api/types.ts#L74). this PR (microsoft/vscode-jupyter#10889) removed it from jupyter since it is not used. but it is never removed from python extension.
...
I am doing this as a part of on-going client move work since we do not want to expose ILanguageServer to pass to jupyter extension unless it is required.