Fix bugs found during TPI - #19925
Merged
Karthik Nadig (karthiknadig) merged 8 commits intoOct 3, 2022
Merged
Conversation
Karthik Nadig (karthiknadig)
requested review from
Kartik Raj (karrtikr) and
Luciana Abud (luabud)
September 30, 2022 21:18
Karthik Nadig (karthiknadig)
marked this pull request as ready for review
September 30, 2022 22:10
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
Hard to verify so many issues with one PR, can you add the next milestone to all these issues so they can be verified? LGTM otherwise.
Karthik Nadig (karthiknadig)
requested review from
Kartik Raj (karrtikr) and
Luciana Abud (luabud)
October 3, 2022 15:41
Kartik Raj (karrtikr)
changed the title
I still do not see milestones added for each of closed issues. |
Member
Author
|
We will have to verify these before release. So, I will create a bug-bash for this. |
Kartik Raj (karrtikr)
approved these changes
Oct 3, 2022
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Oct 4, 2022
Closes microsoft#19889 Closes microsoft#19890 Closes microsoft#19891 Closes microsoft#19894 Closes microsoft#19897 Closes microsoft#19852 Closes microsoft#19851 Closes microsoft#19838 Closes microsoft#19916 Closes microsoft#19917
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
Closes microsoft/vscode-python#19889 Closes microsoft/vscode-python#19890 Closes microsoft/vscode-python#19891 Closes microsoft/vscode-python#19894 Closes microsoft/vscode-python#19897 Closes microsoft/vscode-python#19852 Closes microsoft/vscode-python#19851 Closes microsoft/vscode-python#19838 Closes microsoft/vscode-python#19916 Closes microsoft/vscode-python#19917
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19889
Closes #19890
Closes #19891
Closes #19894
Closes #19897
Closes #19852
Closes #19851
Closes #19838
Closes #19916
Closes #19917