Add Pytest Code But Keep Inactive for Pytest Discovery - #20210
Closed
Eleanor Boyd (eleanorjboyd) wants to merge 35 commits into
Closed
Add Pytest Code But Keep Inactive for Pytest Discovery#20210Eleanor Boyd (eleanorjboyd) wants to merge 35 commits into
Eleanor Boyd (eleanorjboyd) wants to merge 35 commits into
Conversation
Eleanor Boyd (eleanorjboyd)
requested review from
Brett Cannon (brettcannon) and
Karthik Nadig (karthiknadig)
November 10, 2022 23:30
Karthik Nadig (karthiknadig)
requested changes
Nov 10, 2022
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
November 11, 2022 19:42
Eleanor Boyd (eleanorjboyd)
requested a review
from Karthik Nadig (karthiknadig)
November 11, 2022 19:43
Eleanor Boyd (eleanorjboyd)
requested a review
from Karthik Nadig (karthiknadig)
December 19, 2022 16:30
Eleanor Boyd (eleanorjboyd)
requested review from
Kartik Raj (karrtikr) and
Karthik Nadig (karthiknadig)
January 24, 2023 22:45
Kartik Raj (karrtikr)
previously approved these changes
Jan 31, 2023
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
I see other console.* calls as well.
Member
Author
|
closing in favor of #20566 |
Eleanor Boyd (eleanorjboyd)
deleted the
pytest_discovery_inactive_addition
branch
January 31, 2023 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20079