Consistent disposal of receivers across adapters - #21759
Merged
Eleanor Boyd (eleanorjboyd) merged 3 commits intoAug 10, 2023
Merged
Conversation
Eleanor Boyd (eleanorjboyd)
added
the
bug
Member
Author
|
label "skip-test" added for now until tests can be properly written that watch the order in which events happen. Only delayed to get bug fix in |
Eleanor Boyd (eleanorjboyd)
marked this pull request as ready for review
August 4, 2023 17:08
Eleanor Boyd (eleanorjboyd)
requested a review
from Karthik Nadig (karthiknadig)
August 4, 2023 17:08
Eleanor Boyd (eleanorjboyd)
changed the base branch from
main
to
feature-branch-testing-overflow-bug-fix
August 7, 2023 19:57
Karthik Nadig (karthiknadig)
approved these changes
Aug 10, 2023
Eleanor Boyd (eleanorjboyd)
merged commit Aug 10, 2023
b299ec9
into
microsoft:feature-branch-testing-overflow-bug-fix
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Aug 11, 2023
Eleanor Boyd (eleanorjboyd)
added a commit
that referenced
this pull request
Aug 14, 2023
Few items: - every adapter has a disposeDataReceiver function - all disposeDataReceiver functions handle uuid deleting creating a single point of uuid deletion per adapter - always end with the disposal of the receiver to ensure no repeat receivers on retries - cancelation and the end of a subprocess both result in the same function call to cleanup
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Aug 14, 2023
Eleanor Boyd (eleanorjboyd)
added a commit
that referenced
this pull request
Aug 14, 2023
Few items: - every adapter has a disposeDataReceiver function - all disposeDataReceiver functions handle uuid deleting creating a single point of uuid deletion per adapter - always end with the disposal of the receiver to ensure no repeat receivers on retries - cancelation and the end of a subprocess both result in the same function call to cleanup
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Aug 14, 2023
Few items: - every adapter has a disposeDataReceiver function - all disposeDataReceiver functions handle uuid deleting creating a single point of uuid deletion per adapter - always end with the disposal of the receiver to ensure no repeat receivers on retries - cancelation and the end of a subprocess both result in the same function call to cleanup
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Aug 14, 2023
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Aug 14, 2023
Eleanor Boyd (eleanorjboyd)
added a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Aug 14, 2023
…rosoft#21759)"" This reverts commit f0df531.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few items: