Revert "Remove old code for folder support in interpreter path setting" - #22638
Merged
Merged
Conversation
Kartik Raj (karrtikr)
added
bug
Anthony Kim (anthonykim1)
approved these changes
Dec 12, 2023
Kartik Raj (karrtikr)
enabled auto-merge (squash)
December 12, 2023 23:20
Kartik Raj (karrtikr)
deleted the
revert-22413-kartik/compact-vulture
branch
December 12, 2023 23:23
Kartik Raj (karrtikr)
pushed a commit
that referenced
this pull request
Dec 13, 2023
Following up to #22638
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Dec 13, 2023
…g" (microsoft#22638) Reverts microsoft#22413 microsoft#22618 Turns out we still need this code for old deprecated APIs that we expose, one of which is used in testing.
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Dec 13, 2023
Following up to microsoft#22638
Karthik Nadig (karthiknadig)
pushed a commit
that referenced
this pull request
Dec 13, 2023
Following up to #22638
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…1 from upstream Merge pull request #297 from posit-dev/merge/upstream-aug-2023.22.1 Merge vscode-python 2023.22.1 from upstream -------------------- Commit message for posit-dev/positron-python@e0d7a6a: Merge commit 'c26d5e79cfeea424a077f8703455de7e9ac7437e' -------------------- Commit message for posit-dev/positron-python@c26d5e7: update version for point release 2023.22.1 -------------------- Commit message for posit-dev/positron-python@c3364b5: More fixes to pre-release (posit-dev/positron-python#22641) Further followup to microsoft/vscode-python#22640 -------------------- Commit message for posit-dev/positron-python@0a570b5: More fixes to pre-release (posit-dev/positron-python#22640) Following up to microsoft/vscode-python#22638 -------------------- Commit message for posit-dev/positron-python@a712e12: Fix localization failure for pre-release (posit-dev/positron-python#22639) Fixes pre-release, dynamic strings are not supported by localization. -------------------- Commit message for posit-dev/positron-python@d31b870: Revert "Remove old code for folder support in interpreter path setting" (posit-dev/positron-python#22638) Reverts microsoft/vscode-python#22413 microsoft/vscode-python#22618 Turns out we still need this code for old deprecated APIs that we expose, one of which is used in testing. -------------------- Commit message for posit-dev/positron-python@780870a: finalized-release-2023.22 (posit-dev/positron-python#22608) update to final release number for 2023.22 Lead-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com> Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com> Signed-off-by: GitHub <noreply@github.com>
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…1 from upstream Merge pull request #297 from posit-dev/merge/upstream-aug-2023.22.1 Merge vscode-python 2023.22.1 from upstream -------------------- Commit message for posit-dev/positron-python@e0d7a6a: Merge commit 'c26d5e79cfeea424a077f8703455de7e9ac7437e' -------------------- Commit message for posit-dev/positron-python@c26d5e7: update version for point release 2023.22.1 -------------------- Commit message for posit-dev/positron-python@c3364b5: More fixes to pre-release (posit-dev/positron-python#22641) Further followup to microsoft/vscode-python#22640 -------------------- Commit message for posit-dev/positron-python@0a570b5: More fixes to pre-release (posit-dev/positron-python#22640) Following up to microsoft/vscode-python#22638 -------------------- Commit message for posit-dev/positron-python@a712e12: Fix localization failure for pre-release (posit-dev/positron-python#22639) Fixes pre-release, dynamic strings are not supported by localization. -------------------- Commit message for posit-dev/positron-python@d31b870: Revert "Remove old code for folder support in interpreter path setting" (posit-dev/positron-python#22638) Reverts microsoft/vscode-python#22413 microsoft/vscode-python#22618 Turns out we still need this code for old deprecated APIs that we expose, one of which is used in testing. -------------------- Commit message for posit-dev/positron-python@780870a: finalized-release-2023.22 (posit-dev/positron-python#22608) update to final release number for 2023.22 Lead-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: eleanorjboyd <eleanorboyd@microsoft.com> Co-authored-by: Wasim Lorgat <mwlorgat@gmail.com> Signed-off-by: GitHub <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #22413 #22618
Turns out we still need this code for old deprecated APIs that we expose, one of which is used in testing.