If type identifier for an environment is not registered, infer type from locator - #23083
Merged
Conversation
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
added
bug
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
marked this pull request as ready for review
March 16, 2024 23:27
3 tasks
Kartik Raj (karrtikr)
enabled auto-merge (squash)
March 16, 2024 23:29
Benjamin Pasero (bpasero)
approved these changes
Mar 17, 2024
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 5, 2024
…rom locator (microsoft/vscode-python#23083) For microsoft/vscode-python#22810 ...so in case of Hatch, as an [explicit Hatch identifier is not available](microsoft/vscode-python#22779 (comment)), we infer an environment is Hatch if we get it from the Hatch locator: microsoft/vscode-python#22779.
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 8, 2024
…rom locator (microsoft/vscode-python#23083) For microsoft/vscode-python#22810 ...so in case of Hatch, as an [explicit Hatch identifier is not available](microsoft/vscode-python#22779 (comment)), we infer an environment is Hatch if we get it from the Hatch locator: microsoft/vscode-python#22779.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #22810
...so in case of Hatch, as an explicit Hatch identifier is not available, we infer an environment is Hatch if we get it from the Hatch locator: #22779.