Resolve test suite execution import errors due to path ordering - #23099
Merged
Conversation
Karthik Nadig (karthiknadig)
requested a review
from Eleanor Boyd (eleanorjboyd)
March 20, 2024 20:08
Karthik Nadig (karthiknadig)
added
the
bug
Member
|
updated branch and running checks now- sorry for the delay! |
Eleanor Boyd (eleanorjboyd)
requested review from
Anthony Kim (anthonykim1) and
Karthik Nadig (karthiknadig)
March 29, 2024 18:25
Eleanor Boyd (eleanorjboyd)
approved these changes
Mar 29, 2024
Eleanor Boyd (eleanorjboyd)
left a comment
Eleanor Boyd (eleanorjboyd)
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution!
Anthony Kim (anthonykim1)
approved these changes
Mar 29, 2024
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 5, 2024
…osoft/vscode-python#23099) - This has already been discussed and resolved for tests discovery in this [PR](microsoft/vscode-python#22454) - I have now run into the same issue for executing the test suite and have applied the same fix in this PR - Tested and working [Issue](microsoft/vscode-python#23098) for this current PR [Original Issue](microsoft/vscode-python#22453) [Original PR](microsoft/vscode-python#22454) Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Apr 8, 2024
…osoft/vscode-python#23099) - This has already been discussed and resolved for tests discovery in this [PR](microsoft/vscode-python#22454) - I have now run into the same issue for executing the test suite and have applied the same fix in this PR - Tested and working [Issue](microsoft/vscode-python#23098) for this current PR [Original Issue](microsoft/vscode-python#22453) [Original PR](microsoft/vscode-python#22454) Co-authored-by: Eleanor Boyd <eleanorboyd@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this current PR
Original Issue
Original PR