Skip to content

Conda and Known Python Tests - #23349

Merged
Don Jayamanne (DonJayamanne) merged 7 commits into
native_locatorfrom
testing
May 7, 2024
Merged

Conda and Known Python Tests#23349
Don Jayamanne (DonJayamanne) merged 7 commits into
native_locatorfrom
testing

Conversation

@DonJayamanne

Copy link
Copy Markdown

No description provided.

@DonJayamanne Don Jayamanne (DonJayamanne) added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels May 6, 2024
Comment thread native_locator/Cargo.toml
test = []

[lib]
doctest = false

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just disables docs validation. We don't have any tests, I don't think we need to explicitly disable it. Unless it causes issues with CI runs.

@karthiknadig

Copy link
Copy Markdown
Member

We discussed offline. Move the rust test running out of nox and into its own check as "Native Tests"

Comment thread native_locator/tests/common/mod.rs
@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 1b0c881 into native_locator May 7, 2024
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the testing branch May 7, 2024 00:19
Anthony Kim (anthonykim1) pushed a commit to anthonykim1/vscode-python that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants