Skip to content

Add native homebrew locator on mac - #23363

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
native_locatorfrom
homevrewSupport
May 7, 2024
Merged

Add native homebrew locator on mac#23363
Don Jayamanne (DonJayamanne) merged 2 commits into
native_locatorfrom
homevrewSupport

Conversation

@DonJayamanne

Copy link
Copy Markdown

No description provided.

case 'conda':
return PythonEnvKind.Conda;
case 'system':
case 'homebrew':

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?
We can discuss tomorrow, feel free to leave a comment.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. We can always discard what we don’t need on the TS side.

@DonJayamanne Don Jayamanne (DonJayamanne) changed the title Add native homebrew locator Add native homebrew locator on mac May 7, 2024
@DonJayamanne Don Jayamanne (DonJayamanne) added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels May 7, 2024
@DonJayamanne
Don Jayamanne (DonJayamanne) marked this pull request as ready for review May 7, 2024 05:48
@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 2d383e0 into native_locator May 7, 2024
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the homevrewSupport branch May 7, 2024 05:48
@vscodenpa VS Code Bot (vscodenpa) added this to the May 2024 milestone May 7, 2024
Anthony Kim (anthonykim1) pushed a commit to anthonykim1/vscode-python that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants