Restore execute bits on deactivate scripts - #23620
Merged
Merged
Conversation
Christopher Covington (covracer)
force-pushed
the
chmod+x
branch
from
June 14, 2024 12:57
0ed2f05 to
068c826
Compare
Christopher Covington (covracer)
force-pushed
the
chmod+x
branch
from
June 14, 2024 12:59
068c826 to
d358604
Compare
Christopher Covington (covracer)
changed the title
Author
|
@microsoft-github-policy-service agree |
Karthik Nadig (karthiknadig)
added
the
bug
Karthik Nadig (karthiknadig)
approved these changes
Jun 17, 2024
Karthik Nadig (karthiknadig)
requested review from
Anthony Kim (anthonykim1) and
Eleanor Boyd (eleanorjboyd)
June 17, 2024 16:20
Karthik Nadig (karthiknadig)
enabled auto-merge (squash)
June 17, 2024 16:21
|
Thank you for doing this |
Anthony Kim (anthonykim1)
approved these changes
Jun 17, 2024
Don Jayamanne (DonJayamanne)
pushed a commit
that referenced
this pull request
Jun 24, 2024
#22921 removed executable bits: ```diff diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate old mode 100755 new mode 100644 similarity index 100% rename from pythonFiles/deactivate/bash/deactivate rename to python_files/deactivate/bash/deactivate ``` https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d Set them back. Fixes #23449 and #23195
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jun 28, 2024
microsoft#22921 removed executable bits: ```diff diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate old mode 100755 new mode 100644 similarity index 100% rename from pythonFiles/deactivate/bash/deactivate rename to python_files/deactivate/bash/deactivate ``` https://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d Set them back. Fixes microsoft#23449 and microsoft#23195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22921 removed executable bits:
diff --git a/pythonFiles/deactivate/bash/deactivate b/python_files/deactivate/bash/deactivate old mode 100755 new mode 100644 similarity index 100% rename from pythonFiles/deactivate/bash/deactivate rename to python_files/deactivate/bash/deactivatehttps://github.com/microsoft/vscode-python/pull/22921/files#diff-796809259ce3b33f54a33371e898048faf2f7f912cd1bbe11059feb40a63a58d
Set them back.
Fixes #23449 and Fixes #23195