Hide Run Python option when in Jupyter Notebook - #23732
Merged
Anthony Kim (anthonykim1) merged 2 commits intoJul 9, 2024
Merged
Hide Run Python option when in Jupyter Notebook#23732Anthony Kim (anthonykim1) merged 2 commits into
Anthony Kim (anthonykim1) merged 2 commits into
Conversation
Anthony Kim (anthonykim1)
added
debt
Anthony Kim (anthonykim1)
requested review from
Karthik Nadig (karthiknadig) and
Peng Lyu (rebornix)
July 2, 2024 22:51
Anthony Kim (anthonykim1)
marked this pull request as ready for review
July 2, 2024 22:51
Karthik Nadig (karthiknadig)
previously approved these changes
Jul 3, 2024
| "submenu": "python.run", | ||
| "group": "Python", | ||
| "when": "editorLangId == python && !virtualWorkspace && shellExecutionSupported && isWorkspaceTrusted" | ||
| "when": "editorLangId == python && !virtualWorkspace && shellExecutionSupported && isWorkspaceTrusted && !jupyter.ownsSelection && !notebookEditorFocused " |
There was a problem hiding this comment.
there is an additional whitespace at the end. Also I wonder if !notebookEditorFocused is sufficient as we just want to filter out all notebooks.
If we only want to filter out Jupyter notebook, but not necessarily other custom notebook (including repl), then the check is notebookType != jupyter-notebook
There was a problem hiding this comment.
thanks for input! Just made changes to 4ac4ab3 adding notebookType != jupyter-notebook to only exclude notebook and include REPL
Anthony Kim (anthonykim1)
requested review from
Karthik Nadig (karthiknadig) and
Peng Lyu (rebornix)
July 8, 2024 21:50
Paula (paulacamargo25)
approved these changes
Jul 9, 2024
Eleanor Boyd (eleanorjboyd)
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #22739