Correctly display native REPL execution status - #23797
Conversation
Anthony Kim (anthonykim1)
added
feature-request
Don Jayamanne (DonJayamanne)
left a comment
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
Not convinced the test for failure is the right approach.
Users can print anything to the output. that shoudln't be used as a way to determine success/failure.
Karthik Nadig (karthiknadig)
left a comment
Karthik Nadig (karthiknadig)
left a comment
There was a problem hiding this comment.
Change REPL server message to return execution status.
| return True | ||
| except KeyboardInterrupt: | ||
| print(traceback.format_exc()) | ||
| return False |
There was a problem hiding this comment.
This should be a different status right? Interrupted, does not really fall into pass/fail
There was a problem hiding this comment.
I think it is still fail judging from the interactive window (from Jupyter) behavior.
| new vscode.NotebookCellOutput([vscode.NotebookCellOutputItem.text(result.output, 'text/plain')]), | ||
| ]); | ||
| exec.end(false); | ||
| // TODO: Properly update via NotebookCellOutputItem.error later. |
There was a problem hiding this comment.
Can you point me to the bug you filed for this on Jupyter?
There was a problem hiding this comment.
Yeap of course: microsoft/vscode-jupyter#15855
There was a problem hiding this comment.
I'm not sure I understand the issue here, .NET, Julia, R and others are using VS COde Notebook API today, hence not sure how/why the existing API is not sufficient.
There was a problem hiding this comment.
Not sure this is the right approach, if there are failures, then you need to use error output, not text.
Not sure text output has been used here.
There was a problem hiding this comment.
Just added some question, response in microsoft/vscode-jupyter#15855
I did take a look at Julia repo and see they are using .error on their error output as we desired too.
Don Jayamanne (@DonJayamanne) Do you also know a way to use julia in interactive window? I cant locate some sort of dropdown/command to launch interactive window with julia kernel.
There was a problem hiding this comment.
julia-vscode/julia-vscode#2713 (comment) seems to be the most closest I can find as launching with some? drawbacks.
stale
3 participants
Resolves: #23739