Switch over to executeCommand from sendText - #24078
Merged
Anthony Kim (anthonykim1) merged 37 commits intoSep 12, 2024
Merged
Conversation
Anthony Kim (anthonykim1)
added
feature-request
| @@ -146,9 +146,13 @@ export class SynchronousTerminalService implements ITerminalService, Disposable | |||
| lockFile.dispose(); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
We should use less of these services when possible.
…dTerminalShellExecution
Anthony Kim (anthonykim1)
marked this pull request as ready for review
September 11, 2024 19:57
Anthony Kim (anthonykim1)
requested a review
from Karthik Nadig (karthiknadig)
September 11, 2024 20:10
Karthik Nadig (karthiknadig)
requested changes
Sep 11, 2024
Anthony Kim (anthonykim1)
marked this pull request as draft
September 12, 2024 01:16
Anthony Kim (anthonykim1)
marked this pull request as ready for review
September 12, 2024 01:22
Anthony Kim (anthonykim1)
requested a review
from Karthik Nadig (karthiknadig)
September 12, 2024 02:43
| await initialize(); | ||
| return undefined; | ||
| }); | ||
| // TODO: This test is being flaky for windows, need to investigate why only fails on windows |
There was a problem hiding this comment.
Do we have a debt item for this? and also for the TODO to change how terminal is saved.
Karthik Nadig (karthiknadig)
requested changes
Sep 12, 2024
Karthik Nadig (karthiknadig)
left a comment
Karthik Nadig (karthiknadig)
left a comment
Member
There was a problem hiding this comment.
some minor things to change
Karthik Nadig (karthiknadig)
previously approved these changes
Sep 12, 2024
Karthik Nadig (karthiknadig)
previously approved these changes
Sep 12, 2024
Anthony Kim (anthonykim1)
marked this pull request as draft
September 12, 2024 18:47
Anthony Kim (anthonykim1)
marked this pull request as ready for review
September 12, 2024 19:35
Anthony Kim (anthonykim1)
requested a review
from Karthik Nadig (karthiknadig)
September 12, 2024 19:35
Karthik Nadig (karthiknadig)
approved these changes
Sep 12, 2024
Anthony Kim (anthonykim1)
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
Resolves: microsoft#23929 TODO: (debt --> in separate PR) Have ensureTerminal return Promise<Terminal> instead of Promise<void> and saving this in the TerminalService class. Would avoid many uses of the !, and maybe even get to throw away the TerminalService class itself.
Anthony Kim (anthonykim1)
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 15, 2024
Resolves: microsoft#23929 TODO: (debt --> in separate PR) Have ensureTerminal return Promise<Terminal> instead of Promise<void> and saving this in the TerminalService class. Would avoid many uses of the !, and maybe even get to throw away the TerminalService class itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #23929
TODO: (debt --> in separate PR) Have ensureTerminal return Promise instead of Promise and saving this in the TerminalService class. Would avoid many uses of the !, and maybe even get to throw away the TerminalService class itself.